-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Fix block randomization on circuit breaking tests #127909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ivancea
merged 11 commits into
elastic:main
from
ivancea:esql-fix-block-randomization-tests
May 9, 2025
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7e368d7
ESQL Fix and unmute BlockHashTests.test3BytesRefs()
ivancea 676eba4
[CI] Auto commit changes from spotless
783c1a2
Merge branch 'main' into esql-fix-block-hash-test-mutes
ivancea 74604f9
Unmute test and fix issue by avoiding randomization based on call sta…
ivancea 2e7693e
Format
ivancea fa40c16
Merge branch 'main' into esql-fix-block-randomization-tests
ivancea 5c87aca
Fix typo
ivancea bdcf2c5
Merge branch 'main' into esql-fix-block-randomization-tests
ivancea 4178547
Added options to simple() method
ivancea 8a0965c
Added options to simpleWithMode() method
ivancea d8ac5c0
Remove mute from merge conflict
ivancea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we had C#'s
nameof()to make this more robust. But I think adding that link in the javadoc is the only simple option we have (?)