Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,6 @@ tests:
- class: org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryIT
method: testStopQueryLocal
issue: https://github.com/elastic/elasticsearch/issues/125946
- class: org.elasticsearch.upgrades.SemanticTextUpgradeIT
method: testSemanticTextOperations {p0=true}
issue: https://github.com/elastic/elasticsearch/issues/127937
- class: org.elasticsearch.upgrades.SemanticTextUpgradeIT
method: testSemanticTextOperations {p0=false}
issue: https://github.com/elastic/elasticsearch/issues/127938

# Examples:
#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand All @@ -43,16 +44,35 @@ public static TestModel createRandomInstance() {
}

public static TestModel createRandomInstance(TaskType taskType) {
return createRandomInstance(taskType, null);
return createRandomInstance(taskType, null, null);
}

public static TestModel createRandomInstance(TaskType taskType, List<SimilarityMeasure> excludedSimilarities) {
public static TestModel createRandomInstance(
TaskType taskType,
List<DenseVectorFieldMapper.ElementType> excludedElementTypes,
List<SimilarityMeasure> excludedSimilarities
) {
// Use a max dimension count that has a reasonable probability of being compatible with BBQ
return createRandomInstance(taskType, excludedSimilarities, BBQ_MIN_DIMS * 2);
return createRandomInstance(taskType, excludedElementTypes, excludedSimilarities, BBQ_MIN_DIMS * 2);
}

public static TestModel createRandomInstance(TaskType taskType, List<SimilarityMeasure> excludedSimilarities, int maxDimensions) {
var elementType = taskType == TaskType.TEXT_EMBEDDING ? randomFrom(DenseVectorFieldMapper.ElementType.values()) : null;
public static TestModel createRandomInstance(
TaskType taskType,
List<DenseVectorFieldMapper.ElementType> excludedElementTypes,
List<SimilarityMeasure> excludedSimilarities,
int maxDimensions
) {
List<DenseVectorFieldMapper.ElementType> supportedElementTypes = new ArrayList<>(
Arrays.asList(DenseVectorFieldMapper.ElementType.values())
);
if (excludedElementTypes != null) {
supportedElementTypes.removeAll(excludedElementTypes);
if (supportedElementTypes.isEmpty()) {
throw new IllegalArgumentException("No supported element types with excluded element types " + excludedElementTypes);
}
}

var elementType = taskType == TaskType.TEXT_EMBEDDING ? randomFrom(supportedElementTypes) : null;
var dimensions = taskType == TaskType.TEXT_EMBEDDING
? DenseVectorFieldMapperTestUtils.randomCompatibleDimensions(elementType, maxDimensions)
: null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,13 @@ public class SemanticTextUpgradeIT extends AbstractUpgradeTestCase {
@BeforeClass
public static void beforeClass() {
SPARSE_MODEL = TestModel.createRandomInstance(TaskType.SPARSE_EMBEDDING);
// Exclude bit vectors because semantic text does not fully support them
// Exclude dot product because we are not producing unit length vectors
DENSE_MODEL = TestModel.createRandomInstance(TaskType.TEXT_EMBEDDING, List.of(SimilarityMeasure.DOT_PRODUCT));
DENSE_MODEL = TestModel.createRandomInstance(
TaskType.TEXT_EMBEDDING,
List.of(DenseVectorFieldMapper.ElementType.BIT),
List.of(SimilarityMeasure.DOT_PRODUCT)
);
}

public SemanticTextUpgradeIT(boolean useLegacyFormat) {
Expand Down