Skip to content

Fix #123425 numerical floating point edge case #127982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025
Merged

Fix #123425 numerical floating point edge case #127982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf4752
Fix #123425 numerical floating point edge case
craigtaverner May 9, 2025
d368a4e
Merge branch 'main' into fix123425
craigtaverner May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/geo/src/test/java/org/elasticsearch/geometry/utils/SpatialEnvelopeVisitorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void testVisitGeoPointsWrapping() {
} else {
// Both positive and negative x values exist, we need to decide which way to wrap the bbox
double unwrappedWidth = maxPosX - minNegX;
double wrappedWidth = (180 - minPosX) - (-180 - maxNegX);
double wrappedWidth = 360.0 + maxNegX - minPosX;
if (unwrappedWidth <= wrappedWidth) {
// The smaller bbox is around the front of the planet, no dateline wrapping required
assertRectangleResult(i + ": " + point, result, minNegX, maxPosX, maxY, minY, false);
Expand Down
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,6 @@ tests:
- class: org.elasticsearch.xpack.esql.plugin.DataNodeRequestSenderIT
method: testSearchWhileRelocating
issue: https://github.com/elastic/elasticsearch/issues/127188
- class: org.elasticsearch.geometry.utils.SpatialEnvelopeVisitorTests
method: testVisitGeoPointsWrapping
issue: https://github.com/elastic/elasticsearch/issues/123425
- class: org.elasticsearch.xpack.remotecluster.CrossClusterEsqlRCS2EnrichUnavailableRemotesIT
method: testEsqlEnrichWithSkipUnavailable
issue: https://github.com/elastic/elasticsearch/issues/127368
Expand Down