Fix RestCancellableNodeClientTests
#128085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes elastic#128057
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
DaveCTurner
deleted the
2025/05/14/RestCancellableNodeClientTests-testConcurrentExecuteAndClose-128057
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes elastic#128057
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes elastic#128057
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes elastic#128057
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes elastic#128057
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes #128057
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes #128057
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes #128057
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 15, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes #128057
richard-dennehy
pushed a commit
to richard-dennehy/elasticsearch
that referenced
this pull request
May 19, 2025
These tests set `closeListener` racily, such that it's possible to see it still be `null` in `TestHttpChannel#close()`. This commit replaces it with a `SubscribableListener` so that we always complete the subscribed listener regardless of order. It also fixes a separate race in `testCompletedTasks` where (very rarely) all of the `client.execute` calls had completed their listener without getting to the point where they'd subscribed a `closeListener`. Closes elastic#128057
This was referenced Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests set
closeListenerracily, such that it's possible to seeit still be
nullinTestHttpChannel#close(). This commit replaces itwith a
SubscribableListenerso that we always complete the subscribedlistener regardless of order.
It also fixes a separate race in
testCompletedTaskswhere (veryrarely) all of the
client.executecalls had completed their listenerwithout getting to the point where they'd subscribed a
closeListener.Closes #128057