Simplify testSearchWhileRelocating #128095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change logs the query failure as well as stops the test immediately after it. This makes it easier to read the logs and troubleshot the flaky failures once they happen.
idegtiarenko
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
May 19, 2025
| queries.increment(); | ||
| } | ||
| }); | ||
| }, "testSearchWhileRelocating"); |
Member
There was a problem hiding this comment.
Would it help to have the i in the name?
Contributor
Author
There was a problem hiding this comment.
I would say it is not to important as long as we can identify this is the the source of the threads if they ever picked up by leak detector
Contributor
Author
There was a problem hiding this comment.
Although, there is no disadvantage in having it, will add shortly.
dnhatn
approved these changes
May 19, 2025
idegtiarenko
added
auto-backport
Collaborator
💚 Backport successful
|
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
May 20, 2025
This change logs the query failure as well as stops the test immediately after it. This makes it easier to read the logs and troubleshot the flaky failures once they happen.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change logs the query failure as well as stops the test immediately after it.
This makes it easier to read the logs and troubleshot the flaky failures once they happen.