Skip to content

Debug ManyShardsIT #128127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Debug ManyShardsIT #128127

merged 1 commit into from
May 19, 2025

Conversation

@idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented May 19, 2025

This change:

  • Sets a thread name to confirm this thread is the source of the issue
  • adds interrupted handling (using safeAwait)
  • adds timeout to avoid indefinite waiting
  • adds logging of the possible query failures

I suspect that some of the above might contribute to #127196
This changes should allow to confirm or disprove it.

@idegtiarenko idegtiarenko requested review from dnhatn and nik9000 May 19, 2025 08:11
@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests :Search Relevance/Analysis How text is split into tokens :Analytics/ES|QL AKA ESQL v9.1.0 labels May 19, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels May 19, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 19, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@idegtiarenko idegtiarenko removed :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels May 19, 2025
@elastic elastic deleted a comment from elasticsearchmachine May 19, 2025
@idegtiarenko idegtiarenko added v8.18.2 auto-backport Automatically create backport pull requests when merged labels May 19, 2025
@idegtiarenko idegtiarenko merged commit 6052c5b into elastic:main May 19, 2025
17 checks passed
@idegtiarenko idegtiarenko deleted the debug_ManyShardsIT branch May 19, 2025 14:53
@idegtiarenko idegtiarenko mentioned this pull request May 19, 2025
Closed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 19, 2025

💚 Backport successful

Status Branch Result
✅ 8.18

idegtiarenko added a commit that referenced this pull request May 19, 2025
@idegtiarenko
Debug ManyShardsIT (#128127)
dca62f0 
(cherry picked from commit 6052c5b)
@idegtiarenko idegtiarenko mentioned this pull request May 19, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request May 19, 2025
@idegtiarenko
Debug ManyShardsIT (#128127) (#128138)
31e4aed 
(cherry picked from commit 6052c5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

@dnhatn dnhatn Awaiting requested review from dnhatn

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@idegtiarenko @elasticsearchmachine @nik9000