ESQL: Document VALUES uniques #128157
Merged
ESQL: Document VALUES uniques #128157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents that the VALUES aggregate function returns unique documents and points folks to the TOP aggregate function if they want to keep dupes. Closes elastic#128091
nik9000
added
>docs
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
leemthompo
reviewed
May 20, 2025
...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Values.java
Outdated
Show resolved
Hide resolved
Member
Author
|
As those are the only public docs these days I don't think we will
backport. So that's fine.
…On Tue, May 20, 2025, 4:44 AM Liam Thompson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Values.java
<#128157 (comment)>
:
> + If you need the values returned in order use <<esql-mv_sort>>.""",
appendix = """
+ ::::{note}
+ Use <<esql-top>> if you need to keep repeated values.
⬇️ Suggested change
- If you need the values returned in order use <<esql-mv_sort>>.""",
- appendix = """
- ::::{note}
- Use <<esql-top>> if you need to keep repeated values.
+ If you need the values returned in order use [`MV_SORT`](/reference/query-languages/esql/functions-operators/mv-functions.md#esql-mv_sort).""",
+ appendix = """
+ ::::{note}
+ Use [`TOP`](/reference/query-languages/esql/functions-operators/aggregation-functions.md#esql-top) if you need to keep repeated values.
nit: if this is for 9.x only we should probably eventually get into the
habit of using docsv3 rather than asciidoc syntax
wdyt @craigtaverner <https://github.com/craigtaverner>?
—
Reply to this email directly, view it on GitHub
<#128157 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIW53SKWJMRXDKGUTFL27LTQTAVCNFSM6AAAAAB5OPKSMOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNJTGI4TMNRTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…expression/function/aggregate/Values.java Co-authored-by: Liam Thompson <[email protected]>
leemthompo
reviewed
May 21, 2025
...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Values.java
Outdated
Show resolved
Hide resolved
…expression/function/aggregate/Values.java Co-authored-by: Liam Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents that the VALUES aggregate function returns unique documents and points folks to the TOP aggregate function if they want to keep dupes.
Closes #128091