Skip to content

Fix comment about CircuitBreaker#IN_FLIGHT_REQUESTS. #128192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Fix comment about CircuitBreaker#IN_FLIGHT_REQUESTS. #128192

merged 1 commit into from
May 20, 2025

Conversation

@vsop-479
Copy link
Contributor

@vsop-479 vsop-479 commented May 20, 2025

@vsop-479 vsop-479 requested a review from a team as a code owner May 20, 2025 12:07
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 20, 2025
DaveCTurner
DaveCTurner approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added >non-issue :Distributed Coordination/Network Http and internode communication implementations and removed needs:triage Requires assignment of a team area label labels May 20, 2025
@DaveCTurner DaveCTurner self-assigned this May 20, 2025
@DaveCTurner
Copy link
Contributor

DaveCTurner commented May 20, 2025

@elasticmachine ok to test

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label May 20, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 20, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@vsop-479
Copy link
Contributor Author

vsop-479 commented May 20, 2025

Thanks for promptly review, @DaveCTurner .

I am wondering if we should track writing requests by enhancing CircuitBreaker#IN_FLIGHT_REQUESTS or adding a new breaker.
Normally, it's ok to keep these writing requests untracked. But there may be some case which need many memory to send request, e.g. A coordinator send ShardSearchRequest to many nodes, or master send clusterstate to many nodes.

@DaveCTurner
Copy link
Contributor

DaveCTurner commented May 20, 2025

CI doesn't seem to be running but 🤷 it's a comment change, I am just going to merge.

@DaveCTurner DaveCTurner merged commit be396ae into elastic:main May 20, 2025
5 checks passed
@vsop-479 vsop-479 deleted the fix_inFlight_comment branch May 21, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@DaveCTurner DaveCTurner

Labels

:Distributed Coordination/Network Http and internode communication implementations external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vsop-479 @DaveCTurner @elasticsearchmachine