Use package to suppress warning for entitlement self-test #128223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
May 21, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 21, 2025
…128248) * Use package to suppress warning for entitlement self-test * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
|
(We're backporting it after all, in #128304.) |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 22, 2025
…8223) * Use package to suppress warning for entitlement self-test * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 22, 2025
…128304) * Use package to suppress warning for entitlement self-test * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 22, 2025
…128304) (#128313) * Use package to suppress warning for entitlement self-test * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
To avoid emitting an unnecessary error for the entitlement self-test, we specifically avoided logging when the caller class was
EntitlementSelfTester.Since #127877, we no longer ignore frames for method references, and so the caller class for an entitlement check is the class of the method reference itself, rather than the class in which that method reference was written.
As a consequence, the caller class for the self test is no longer
EntitlementSelfTester, but rather the class of the method reference.Fix
Suppress based on
Packageinstead ofClass. This suppresses entitlement warnings for theorg.elasticsearch.bootstrappackage.Alternatives
We could suppress this warning as we do for other warnings, by configuring log levels. That might be what we want to do for the long term. For the time being, this is a simple PR that allows us to remove our logging workarounds.
We could attempt to determine the enclosing class from the method reference object, but I haven't yet found any way to do so.
getDeclaringClassandgetEnclosingClassboth return null.