-
Notifications
You must be signed in to change notification settings - Fork 25.5k
ES|QL Functions to generate geo_shape geometries from grid cells #128239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we want to move the ST_GEOXXX functions to produce longs only, for performance reasons, and need the convenience functions to display these either as strings or as actual shapes. This is both useful to the users, as well as easier to do manual tests where we visualize the results on a map.
This involved copying the H3 utils from spatial plugin to esql. We should rather find a common location or dependency for these.
…support for geo_point bounds
…ch into esql_grid_aggs
This reverts commit 742d461.
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Hi @craigtaverner, I've created a changelog YAML for you. |
This work was done differently in #129581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
>enhancement
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work in #125143, this PR adds support for generating
geo_shape
geometries for geohash, geotile and geohex grid cells. The reason for removing it from the original PR is that these geometries cannot be used directly for searching for docs, and we were concerned we might give that impression.If a user wishes to search for docs in grid cells they must use the grid cellid. Using geometries will give slightly different results because it does not take into account points that are on the edge of cells (which can only be in one cell, but will be seen to intersect with both geometries), as well as the more extreme case of H3 cells which have edges which follow great circle lines, while Elasticsearch
geo_shape
geometries have edges following mercator projection lines.So these functions primary utility is in visualization of cells in maps, just like visualizing any other geometry, and should not be considered true representations of the grid cells they originally came from. This limitation would be true in any other GIS database and is not specific to Elasticsearch or ES|QL.