Skip to content

Conversation

@lkts
Copy link
Contributor

@lkts lkts commented May 21, 2025

Closing an index with ongoing resharding operation may be problematic. Until the implications of this are tested and understood we'll prevent this from happening. This PR does that.

@lkts lkts requested a review from ankikuma May 21, 2025 16:41
@lkts lkts added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels May 21, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Distributed Indexing Meta label for Distributed Indexing team labels May 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

* Resharding is currently only implemented in Serverless. This service only exposes minimal metadata about resharding
* needed by other services.
*/
public class IndexReshardService {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just needed a place to put reshardingIndices function in and i didn't feel like doing it in MetadataIndexStateService.

Copy link
Contributor

@ankikuma ankikuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkts lkts merged commit ef06bc8 into elastic:main May 22, 2025
18 checks passed
@lkts lkts deleted the close_resharding_index branch May 22, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >non-issue Team:Distributed Indexing Meta label for Distributed Indexing team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants