Improve get-snapshots message for unreadable repository #128273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if the get-snapshots API cannot access one of the repositories we return a fairly low-level message about the problem, perhaps something like `Could not determine repository generation from root blobs`. This message is shown verbatim in the Kibana UI so users need something a little more descriptive. With this commit we wrap the exception in one that indicates the problem in terms that users are more likely to understand. Relates elastic#128208
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
DiannaHohensee
approved these changes
May 28, 2025
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 30, 2025
Today if the get-snapshots API cannot access one of the repositories we return a fairly low-level message about the problem, perhaps something like `Could not determine repository generation from root blobs`. This message is shown verbatim in the Kibana UI so users need something a little more descriptive. With this commit we wrap the exception in one that indicates the problem in terms that users are more likely to understand. Relates elastic#128208
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 30, 2025
…28662) Today if the get-snapshots API cannot access one of the repositories we return a fairly low-level message about the problem, perhaps something like `Could not determine repository generation from root blobs`. This message is shown verbatim in the Kibana UI so users need something a little more descriptive. With this commit we wrap the exception in one that indicates the problem in terms that users are more likely to understand. Relates #128208
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
Today if the get-snapshots API cannot access one of the repositories we return a fairly low-level message about the problem, perhaps something like `Could not determine repository generation from root blobs`. This message is shown verbatim in the Kibana UI so users need something a little more descriptive. With this commit we wrap the exception in one that indicates the problem in terms that users are more likely to understand. Relates elastic#128208
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
Today if the get-snapshots API cannot access one of the repositories we return a fairly low-level message about the problem, perhaps something like `Could not determine repository generation from root blobs`. This message is shown verbatim in the Kibana UI so users need something a little more descriptive. With this commit we wrap the exception in one that indicates the problem in terms that users are more likely to understand. Relates elastic#128208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if the get-snapshots API cannot access one of the repositories we
return a fairly low-level message about the problem, perhaps something
like
Could not determine repository generation from root blobs. Thismessage is shown verbatim in the Kibana UI so users need something a
little more descriptive. With this commit we wrap the exception in one
that indicates the problem in terms that users are more likely to
understand.
Relates #128208