Skip to content

Pick coordinating node #128288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pick coordinating node #128288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f0d57e
Pick coordinating node
idegtiarenko May 22, 2025
2791e8d
[CI] Auto commit changes from spotless
May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...n/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/ManyShardsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;

import static org.hamcrest.Matchers.allOf;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.greaterThanOrEqualTo;
import static org.hamcrest.Matchers.instanceOf;
import static org.hamcrest.Matchers.lessThanOrEqualTo;
import static org.hamcrest.Matchers.lessThan;

/**
* Make sures that we can run many concurrent requests with large number of shards with any data_partitioning.
Expand Down Expand Up @@ -264,7 +266,7 @@ public void testLimitConcurrentShards() {
public void testCancelUnnecessaryRequests() {
assumeTrue("Requires pragmas", canUseQueryPragmas());
internalCluster().ensureAtLeastNumDataNodes(3);

var dataNodes = internalCluster().numDataNodes();
var coordinatingNode = internalCluster().getNodeNames()[0];

var exchanges = new AtomicInteger(0);
Expand All @@ -281,9 +283,9 @@ public void testCancelUnnecessaryRequests() {
query.query("from test-* | LIMIT 1");
query.pragmas(new QueryPragmas(Settings.builder().put(QueryPragmas.MAX_CONCURRENT_NODES_PER_CLUSTER.getKey(), 1).build()));

try (var result = safeGet(client().execute(EsqlQueryAction.INSTANCE, query))) {
try (var result = safeGet(client(coordinatingNode).execute(EsqlQueryAction.INSTANCE, query))) {
assertThat(Iterables.size(result.rows()), equalTo(1L));
assertThat(exchanges.get(), lessThanOrEqualTo(2));
assertThat(exchanges.get(), allOf(greaterThanOrEqualTo(1), lessThan(dataNodes)));
} finally {
coordinatorNodeTransport.clearAllRules();
}
Expand Down
Loading