Fix thread leak in ManyShardsIT #128321
Merged
Fix thread leak in ManyShardsIT #128321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nik9000
approved these changes
May 22, 2025
ldematte
approved these changes
May 22, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
LGTM; since this is a generic thing, it's "surprising" to have this parallel. Better be sequential by default (if someone is in the special situation of needing to do a parallel count due to size, they should be the special case)
dnhatn
approved these changes
May 22, 2025
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
May 23, 2025
(cherry picked from commit 2f01d17)
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
Iterables.sizeis implemented as following:please note the second parameter passed to
streamcall:parallel=true.A parallel stream starts a fork join ForkJoinPool. It is never closed here as stream is not closed explicitly nor used in try block.
This results in a thread leak that was detected in #127196. Surprisingly it was only happening on JDK 21.
I do not think there is any benefit of counting number of entries concurrently so I am changing the call to use non-parallel stream.
This method is also used in prod, so I am adding core/infra to this review.
Closes: #127196