ESQL: Move some mappers into their expressions #128342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves half of the remaining centralized expression mapper logic into the individual expressions. This is how all but 3 of the remaining expressions work. Let's try and be fully consistent.
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
added
the
auto-backport
Collaborator
💚 Backport successful
|
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
May 29, 2025
This moves half of the remaining centralized expression mapper logic into the individual expressions. This is how all but 3 of the remaining expressions work. Let's try and be fully consistent.
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
This moves half of the remaining centralized expression mapper logic into the individual expressions. This is how all but 3 of the remaining expressions work. Let's try and be fully consistent.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves half of the remaining centralized expression mapper logic into the individual expressions. This is how all but 3 of the remaining expressions work. Let's try and be fully consistent.