Skip to content

Change exceptions to IllegalArgumentException in GroupingDocValuesSelector #128348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Change exceptions to IllegalArgumentException in GroupingDocValuesSelector #128348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/src/main/java/org/elasticsearch/lucene/grouping/GroupingDocValuesSelector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public void setNextReader(LeafReaderContext readerContext) throws IOException {
public boolean advanceExact(int target) throws IOException {
if (sorted.advanceExact(target)) {
if (sorted.docValueCount() > 1) {
throw new IllegalStateException(
throw new IllegalArgumentException(
"failed to extract doc:" + target + ", the grouping field must be single valued"
);
}
Expand All @@ -124,7 +124,7 @@ public long longValue() throws IOException {
};
}
}
default -> throw new IllegalStateException("unexpected doc values type " + type + "` for field `" + field + "`");
default -> throw new IllegalArgumentException("unexpected doc values type " + type + "` for field `" + field + "`");
}
}

Expand Down Expand Up @@ -200,7 +200,7 @@ public void setNextReader(LeafReaderContext readerContext) throws IOException {
public boolean advanceExact(int target) throws IOException {
if (sorted.advanceExact(target)) {
if (sorted.docValueCount() > 1) {
throw new IllegalStateException(
throw new IllegalArgumentException(
"failed to extract doc:" + target + ", the grouping field must be single valued"
);
}
Expand Down Expand Up @@ -233,7 +233,7 @@ public int getValueCount() {
};
}
}
default -> throw new IllegalStateException("unexpected doc values type " + type + "` for field `" + field + "`");
default -> throw new IllegalArgumentException("unexpected doc values type " + type + "` for field `" + field + "`");
}
}

Expand Down