Skip to content

Fix code-callout rendering #128365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Fix code-callout rendering #128365

merged 1 commit into from
May 23, 2025

Conversation

@reakaleek
Copy link
Member

@reakaleek reakaleek commented May 23, 2025

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 23, 2025

@reakaleek please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 23, 2025
@reakaleek reakaleek marked this pull request as ready for review May 23, 2025 11:28
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label May 23, 2025
@leemthompo leemthompo added >docs General docs changes Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v9.0.0 labels May 23, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 23, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 23, 2025

Pinging @elastic/es-docs (Team:Docs)

leemthompo
leemthompo approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic callouts to the rescue 🚀

@leemthompo leemthompo self-assigned this May 23, 2025
@leemthompo leemthompo merged commit cae06b8 into main May 23, 2025
8 of 9 checks passed
@leemthompo leemthompo deleted the reakaleek-patch-1 branch May 23, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@leemthompo leemthompo

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reakaleek @elasticsearchmachine @leemthompo