Use TestUtil.alwaysKnnVectorsFormat where possible in tests #128477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
>test
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
carlosdelest
approved these changes
May 26, 2025
server/src/test/java/org/elasticsearch/index/codec/vectors/ES813FlatVectorFormatTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a minor refactoring of several tests to use
TestUtil.alwaysKnnVectorsFormatwhere possible, rather than extendingLucene101Codec. ThealwaysKnnVectorsFormatstatic method returns anAssertingCodecthat delegates to the default codec for everything exceptKnnVectorsFormat.The primary motivation for this change is to avoid extending a version specific Lucene codec that will require to be updated when Lucene updates its codec ( as can be seen in the
lucene_snapshotbranch, fromLucene101CodectoLucene103Codec).