Revert changes to Text class #128483
Merged
Revert changes to Text class #128483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit db0c3c7.
prdoyle
added
>non-issue
:Core/Infra/Core
elasticsearchmachine
added
serverless-linked
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
JVerwolf
approved these changes
May 26, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 26, 2025
* Revert "Fix the Text class package change in example plugins (elastic#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (elastic#127666)" This reverts commit db0c3c7.
💔 Backport failed
You can use sqren/backport to manually backport by running |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 26, 2025
* Revert "Fix the Text class package change in example plugins (elastic#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (elastic#127666)" This reverts commit db0c3c7.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 26, 2025
* Revert "Fix the Text class package change in example plugins (elastic#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (elastic#127666)" This reverts commit db0c3c7.
|
8.19 backport is here. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 26, 2025
* Revert changes to Text class (#128483) * Revert "Fix the Text class package change in example plugins (#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (#127666)" This reverts commit db0c3c7. * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 27, 2025
* Revert "Fix the Text class package change in example plugins (#128316)" This reverts commit cc48648. * Revert "Update Text class to use native java ByteBuffer (#127666)" This reverts commit db0c3c7. Co-authored-by: Lorenzo Dematté <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
Textto useByteBufferinstead ofBytesReferencehad unintended consequences becauseByteBufferis a mutable, stateful object, whereBytesReferenceis not. Using theByteBuffer(for example, by converting it to aString) "consumes" the buffer's contents and leaves it appearing to be empty.It's urgent to fix this because it's possible this bug could cause data to quietly disappear.
Reverts #128316 and #127666.