Skip to content

ESQL: Reopen testPartiallyPushableSort after fixing #114515 #128522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

ESQL: Reopen testPartiallyPushableSort after fixing #114515 #128522

merged 3 commits into from
Jun 4, 2025

Conversation

@ViggoC
Copy link
Contributor

@ViggoC ViggoC commented May 27, 2025

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v9.1.0 labels May 27, 2025
@nielsbauman nielsbauman added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels Jun 4, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 4, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@alex-spies
Copy link
Contributor

alex-spies commented Jun 4, 2025

Thanks @ViggoC , nice catch!

@alex-spies
Copy link
Contributor

alex-spies commented Jun 4, 2025

@elasticsearchmachine please test this

@alex-spies alex-spies self-requested a review June 4, 2025 15:16
@alex-spies alex-spies self-assigned this Jun 4, 2025
@alex-spies alex-spies added auto-backport Automatically create backport pull requests when merged v8.19.0 labels Jun 4, 2025
alex-spies
alex-spies approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alex-spies
Copy link
Contributor

alex-spies commented Jun 4, 2025

buildkite test this

@alex-spies alex-spies merged commit a90aa97 into elastic:main Jun 4, 2025
20 checks passed
@alex-spies alex-spies mentioned this pull request Jun 4, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 4, 2025

💚 Backport successful

Status Branch Result
✅ 8.19

alex-spies pushed a commit to alex-spies/elasticsearch that referenced this pull request Jun 4, 2025
@ViggoC @alex-spies
ESQL: Un-skip testPartiallyPushableSort after fixing elastic#114515 (e…
022970c 
…lastic#128522)
elasticsearchmachine pushed a commit that referenced this pull request Jun 11, 2025
@alex-spies @ViggoC
ESQL: Un-skip testPartiallyPushableSort after fixing #114515 (#128522) (
d52dfc5 
#128918)

Co-authored-by: ViggoC <[email protected]>
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 11, 2025
@alex-spies @ViggoC @mridula-s109
ESQL: Un-skip testPartiallyPushableSort after fixing elastic#114515 (e…
9ac82df 
…lastic#128522) (elastic#128918)

Co-authored-by: ViggoC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-spies alex-spies alex-spies approved these changes

Assignees

@alex-spies alex-spies

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViggoC @elasticsearchmachine @alex-spies @nielsbauman