Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented May 27, 2025

This PR cleans up links in the Elasticsearch settings pages to point to https://www.elastic.co/docs/deploy-manage/stack-settings#dynamic-cluster-setting and https://www.elastic.co/docs/deploy-manage/stack-settings#static-cluster-setting instead of the API reference.

@lcawl lcawl added >docs General docs changes Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v9.1.0 v9.0.3 labels May 27, 2025
@lcawl lcawl requested a review from a team May 28, 2025 00:06
@lcawl lcawl marked this pull request as ready for review May 28, 2025 00:07
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shainaraskas
Copy link
Contributor

I'd prefer the link go here instead: https://www.elastic.co/docs/deploy-manage/stack-settings#dynamic-cluster-setting

same info, but in a central place that makes the page valid for all deployment types that use this reference.

this was introduced after the site went live so redirects aren't there unfortunately

these settings look mostly relevant to self managed so it's not critical, but might be nice just in a case.

@leemthompo
Copy link
Contributor

Sorry— I have the muscle memory of approving seemingly simple PRs that ask for es-docs reviews to unblock 🙈

We should probably start phasing out the use of that group in favor of the more targeted teams

@shainaraskas
Copy link
Contributor

shainaraskas commented May 28, 2025

@leemthompo I think we would have both been tagged on this one anyway because there are both cluster + search settings

@lcawl lcawl changed the title [DOCS] Edit dynamic setting links [DOCS] Edit dynamic and static setting links May 28, 2025
@lcawl
Copy link
Contributor Author

lcawl commented May 28, 2025

I'd prefer the link go here instead: https://www.elastic.co/docs/deploy-manage/stack-settings#dynamic-cluster-setting

Fixed in 78bce59 (and did all the "static" links too while I was there).

@lcawl lcawl merged commit 3b54afd into elastic:main May 29, 2025
7 checks passed
@lcawl lcawl deleted the setting-links branch May 29, 2025 15:00
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128537

@lcawl
Copy link
Contributor Author

lcawl commented May 29, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/elasticsearch that referenced this pull request May 29, 2025
leemthompo pushed a commit that referenced this pull request Jun 2, 2025
joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Jun 3, 2025
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes Team:Docs Meta label for docs team v9.0.3 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants