-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[DOCS] Edit dynamic and static setting links #128537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-docs (Team:Docs) |
leemthompo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
I'd prefer the link go here instead: https://www.elastic.co/docs/deploy-manage/stack-settings#dynamic-cluster-setting same info, but in a central place that makes the page valid for all deployment types that use this reference. this was introduced after the site went live so redirects aren't there unfortunately these settings look mostly relevant to self managed so it's not critical, but might be nice just in a case. |
|
Sorry— I have the muscle memory of approving seemingly simple PRs that ask for We should probably start phasing out the use of that group in favor of the more targeted teams |
|
@leemthompo I think we would have both been tagged on this one anyway because there are both cluster + search settings |
Fixed in 78bce59 (and did all the "static" links too while I was there). |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 3b54afd)
This PR cleans up links in the Elasticsearch settings pages to point to https://www.elastic.co/docs/deploy-manage/stack-settings#dynamic-cluster-setting and https://www.elastic.co/docs/deploy-manage/stack-settings#static-cluster-setting instead of the API reference.