-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Re-enable and fix the EsqlRestValidationIT test #128542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Stas!
| super.testExistentIndexWithoutWildcard(); | ||
| } | ||
|
|
||
| private static boolean checkVersion(Version version) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we inline this method? The method name does not match its semantics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, can do
* Re-enable and fix the EsqlRestValidationIT test
This test seems to be unintentionally disabled in 9.x branch.
Fixes #128543