Skip to content

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented May 28, 2025

This test seems to be unintentionally disabled in 9.x branch.

Fixes #128543

@smalyshev smalyshev added >test Issues or PRs that are addressing/adding tests :Search Foundations/CCS :Analytics/ES|QL AKA ESQL labels May 28, 2025
@smalyshev smalyshev marked this pull request as ready for review May 28, 2025 16:31
@smalyshev smalyshev requested a review from dnhatn May 28, 2025 16:31
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels May 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Stas!

super.testExistentIndexWithoutWildcard();
}

private static boolean checkVersion(Version version) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we inline this method? The method name does not match its semantics.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do

@smalyshev smalyshev merged commit 5c48295 into elastic:main May 28, 2025
18 checks passed
@smalyshev smalyshev deleted the fix-validation-test branch May 28, 2025 20:57
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
* Re-enable and fix the EsqlRestValidationIT test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL :Search Foundations/CCS Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EsqlRestValidationIT fails

3 participants