Redistribute shards evenly when reconciling #128546
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're reconciling a desired balance, we round-robin to ensure we evacuate shards fairly from all nodes that need evacuation (see
DesiredBalance#moveOrdering). We do not currently round-robin the destination of those movements, we merely make the first move that is allowed.This change updates
DesiredBalance#allocationOrderingeach time we move a shard TO a node, and sorts the candidate target node IDs for a move by that ordering. This means that when given a choice, we will prioritise the least-recently moved-to or allocated-to node for each move.Relates: ES-11706