Skip to content

Script for indexing micro benchmark results #128557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2025
Merged

Script for indexing micro benchmark results #128557

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1498dd6
Script for indexing micro benchmark results
idegtiarenko May 28, 2025
7cf6370
use esbench for now
idegtiarenko May 28, 2025
969f5d2
Merge branch 'main' into index_micro_benchmarks_results
idegtiarenko Jun 2, 2025
a18428c
move credentials
idegtiarenko Jun 2, 2025
4fb1639
use credentials
idegtiarenko Jun 2, 2025
41941bc
fix script location
idegtiarenko Jun 2, 2025
0697c91
append timestamp field
idegtiarenko Jun 2, 2025
3d3e67b
fix field appending
idegtiarenko Jun 2, 2025
a3e6523
remove timestamp quotes
idegtiarenko Jun 2, 2025
5c2bc3a
Merge branch 'main' into index_micro_benchmarks_results
idegtiarenko Jun 2, 2025
b0d70e8
Merge branch 'main' into index_micro_benchmarks_results
idegtiarenko Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/pipelines/periodic-micro-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ steps:
- label: periodic-micro-benchmarks
command: |
.ci/scripts/run-gradle.sh -p benchmarks/ run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json'
.ci/scripts/index-micro-benchmark-results.sh
timeout_in_minutes: 300
agents:
provider: gcp
Expand Down
13 changes: 13 additions & 0 deletions .buildkite/scripts/index-micro-benchmark-results.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/bin/bash

METRICS_HOST=$(vault read -field=es_host /secret/performance/employees/cloud/esbench-metrics)
METRICS_INDEX_NAME="dummy-micro-benchmarks"
Copy link
Contributor Author

@idegtiarenko idegtiarenko May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index name is temporary and will be replaced with a data stream soon

METRICS_USERNAME=$(vault read -field=es_username /secret/performance/employees/cloud/esbench-metrics)
METRICS_PASSWORD=$(vault read -field=es_password /secret/performance/employees/cloud/esbench-metrics)

jq -c '.[]' "benchmarks/build/result.json" | while read -r doc; do
curl -s -X POST "https://$METRICS_HOST/$METRICS_INDEX_NAME/_doc" \
-u "$METRICS_USERNAME:$METRICS_PASSWORD" \
Copy link
Contributor

@breskeby breskeby May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we leak the credentials here to console log? @brianseeders

Copy link
Contributor

@brianseeders brianseeders May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like it, but the vault read commands above need to happen inside of .buildkite/hooks/pre-command. If they happen there, then they will get automatically redacted if they are accidentally printed.

Take a look at the other vault commands in that script, there's a few different ways to do it. I usually prefer introducing an env var like USE_ES_BENCH_CREDENTIALS. You can also do it based on something like the step label periodic-micro-benchmarks, but then it will break if you rename the step.

-H 'Content-Type: application/json' \
-d "$doc"
done