Skip to content

Tolerate incompatible versions with different build hash #128589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2025
Merged

Tolerate incompatible versions with different build hash #128589

merged 5 commits into from
Jun 20, 2025

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented May 28, 2025 •
edited
Loading

Tolerate incompatible versions with different build hash.
I'm keeping the serverless feature flag to not create warnings there.

Relates to ES-11869

@mosche mosche requested review from a team and rjernst May 28, 2025 17:07
@mosche mosche added >non-issue :Core/Infra/Core Core issues without another label labels May 28, 2025
@mosche mosche removed the request for review from rjernst May 28, 2025 17:08
@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Core/Infra Meta label for core/infra team labels May 28, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 28, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update TransportServiceHandshakeTests accordingly

ldematte
ldematte approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DaveCTurner
DaveCTurner previously requested changes May 30, 2025
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, I don't think we can safely remove this without adding more testing of the new upgrade paths that it enables.

@mosche mosche changed the title Tolerate incompatible versions with different build hash [DO NOT MERGE YET] Tolerate incompatible versions with different build hash May 30, 2025
@mosche
Copy link
Contributor Author

mosche commented May 30, 2025

We're working on adding these tests at the moment. Though, we can definitely use the serverless flag initially for these tests and only remove the check once all tests are in place 👍

@mosche mosche marked this pull request as draft May 30, 2025 08:27
@ldematte
Copy link
Contributor

ldematte commented May 30, 2025

++
We can hold off this change off ATM, but rest assured that we are actively working on adding these tests.

@DaveCTurner
Copy link
Contributor

DaveCTurner commented May 30, 2025

I see ok, yes I'd prefer we held off on merging this until we have that test coverage in place. Either that'll be quick (in which case nbd) or it'll take a while (in which case this change will cause a mess with 9.1.0 BCs)

@DaveCTurner DaveCTurner dismissed their stale review May 30, 2025 08:42

tests are WIP elsewhere

@mark-vieira
Copy link
Contributor

mark-vieira commented May 30, 2025

I see ok, yes I'd prefer we held off on merging this until we have that test coverage in place. Either that'll be quick (in which case nbd) or it'll take a while (in which case this change will cause a mess with 9.1.0 BCs)

There's a little bit of a chicken/egg though, we can't merge the testing w/o this change (as the tests would fail). But we can potentially hold off on merging this until the tests are ready and then merge both together.

@DaveCTurner
Copy link
Contributor

DaveCTurner commented May 30, 2025

hold off on merging this until the tests are ready and then merge both together

That would be my preference. Really I just want to avoid creating any 9.1.0 BCs without this check until there's sufficient test coverage. If we can't get the test coverage in place for 9.1.0-BC1 then maybe it'd be better to delay this until after 9.1.0 is fully released.

@mark-vieira mark-vieira mentioned this pull request May 30, 2025
Merged
@ldematte ldematte changed the title [DO NOT MERGE YET] Tolerate incompatible versions with different build hash Tolerate incompatible versions with different build hash Jun 18, 2025
@ldematte ldematte marked this pull request as ready for review June 18, 2025 10:07
@ldematte
Copy link
Contributor

ldematte commented Jun 18, 2025

Now that we have same-version upgrade tests on every PR and intake build, this is safe to merge.
I will let the intake/PR builds run for today, and if there are no problems I'll merge this.

@ldematte ldematte enabled auto-merge (squash) June 19, 2025 15:05
@ldematte ldematte merged commit 9b2ca99 into elastic:main Jun 20, 2025
27 checks passed
@ldematte ldematte mentioned this pull request Jun 20, 2025
Merged
ldematte added a commit that referenced this pull request Jun 23, 2025
@ldematte
Remove es.serverless_transport=true (#129760)
81bb0b5 
Now that #128589, we do not need to use the serverless FF to skip the check.
This PR removes it.

Relates to https://elasticco.atlassian.net/browse/ES-12004
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Jun 23, 2025
@mosche @kderusso
Tolerate incompatible versions with different build hash (elastic#128589
de03488 
)

Tolerate incompatible versions with different build hash.
I'm keeping the serverless feature flag to not create warnings there.

Relates to ES-11869
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Jun 23, 2025
@ldematte @kderusso
Remove es.serverless_transport=true (elastic#129760)
b79479e 
Now that elastic#128589, we do not need to use the serverless FF to skip the check.
This PR removes it.

Relates to https://elasticco.atlassian.net/browse/ES-12004
julian-elastic pushed a commit to julian-elastic/elasticsearch that referenced this pull request Jun 24, 2025
@ldematte @julian-elastic
Remove es.serverless_transport=true (elastic#129760)
3db3aea 
Now that elastic#128589, we do not need to use the serverless FF to skip the check.
This PR removes it.

Relates to https://elasticco.atlassian.net/browse/ES-12004
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
@mosche @mridula-s109
Tolerate incompatible versions with different build hash (elastic#128589
1226b2f 
)

Tolerate incompatible versions with different build hash.
I'm keeping the serverless feature flag to not create warnings there.

Relates to ES-11869
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
@ldematte @mridula-s109
Remove es.serverless_transport=true (elastic#129760)
22c0655 
Now that elastic#128589, we do not need to use the serverless FF to skip the check.
This PR removes it.

Relates to https://elasticco.atlassian.net/browse/ES-12004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

@DaveCTurner DaveCTurner DaveCTurner left review comments

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mosche @elasticsearchmachine @ldematte @DaveCTurner @mark-vieira