Skip to content

Conversation

@masseyke
Copy link
Member

This removes the feature flag that was introduced in #127858, making the data stream settings APIs available without having to pass a flag..

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label May 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I left one comment

private static final Logger LOGGER = LogManager.getLogger(DataStream.class);

public static final NodeFeature DATA_STREAM_FAILURE_STORE_FEATURE = new NodeFeature("data_stream.failure_store");
public static final boolean LOGS_STREAM_FEATURE_FLAG = new FeatureFlag("logs_stream").isEnabled();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this in to use with the mappings stuff and the enable/disable API that Luke is working on?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@masseyke masseyke merged commit dc2fbe1 into elastic:main May 29, 2025
18 checks passed
@masseyke masseyke deleted the remove-data-stream-settings-feature-flag branch May 29, 2025 14:50
joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Jun 3, 2025
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Data streams Data streams and their lifecycles >non-issue Team:Data Management Meta label for data/management team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants