Skip to content

Use all bbq index types in DirectIOIT #128620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Use all bbq index types in DirectIOIT #128620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,14 @@
import java.nio.file.Path;
import java.util.Collection;
import java.util.List;
import java.util.Map;
import java.util.OptionalLong;
import java.util.stream.IntStream;

import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertAcked;
import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertHitCount;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.is;

@LuceneTestCase.SuppressCodecs("*") // only use our own codecs
public class DirectIOIT extends ESIntegTestCase {
Expand Down Expand Up @@ -64,6 +67,7 @@ protected Collection<Class<? extends Plugin>> nodePlugins() {
}

private void indexVectors() {
String type = randomFrom("bbq_flat", "bbq_hnsw");
assertAcked(
prepareCreate("foo-vectors").setSettings(Settings.builder().put(InternalSettingsPlugin.USE_COMPOUND_FILE.getKey(), false))
.setMapping("""
Expand All @@ -76,19 +80,27 @@ private void indexVectors() {
"index": true,
"similarity": "l2_norm",
"index_options": {
"type": "bbq_flat"
"type": "%type%"
}
}
}
}
""")
""".replace("%type%", type))
);
ensureGreen("foo-vectors");

for (int i = 0; i < 1000; i++) {
indexDoc("foo-vectors", Integer.toString(i), "fooVector", IntStream.range(0, 64).mapToDouble(d -> randomFloat()).toArray());
}
refresh();
assertBBQIndexType(type); // test assertion to ensure that the correct index type is being used
}

@SuppressWarnings("unchecked")
static void assertBBQIndexType(String type) {
var response = indicesAdmin().prepareGetFieldMappings("foo-vectors").setFields("fooVector").get();
var map = (Map<String, Object>) response.fieldMappings("foo-vectors", "fooVector").sourceAsMap().get("fooVector");
assertThat((String) ((Map<String, Object>) map.get("index_options")).get("type"), is(equalTo(type)));
}

@TestLogging(value = "org.elasticsearch.index.store.FsDirectoryFactory:DEBUG", reason = "to capture trace logging for direct IO")
Expand Down