Allow project reserved state handlers to update any cluster state #128636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
serverless-linked
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
JVerwolf
approved these changes
May 30, 2025
| * is {@link LocalStateAutoscaling}, therefore we need to provide a test version of this class. | ||
| */ | ||
| public class LocalStateReservedAutoscalingStateHandlerProvider implements ReservedClusterStateHandlerProvider { | ||
| public class LocalStateReservedAutoscalingStateHandlerProvider implements ReservedStateHandlerProvider { |
Contributor
Author
There was a problem hiding this comment.
Implementations of ReservedStateHandlerProvider are loaded via SPI so there's no direct references to the class other than where the provider is registered in META-INF/services or module-info.java.
Contributor
Author
There was a problem hiding this comment.
Also, this particular handler seems to be used only for mocking autoscaling events in tests.
rjernst
approved these changes
May 30, 2025
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
I just skimmed the interface changes, they look good. The rest seems to just be fallout from the name/type changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors our reserved state infrastructure related to project-level reserved state handlers. The initial implementation of project state handlers worked on
ProjectMetadataon the assumption that all per-project state will live there, however, this is not always the case. We may want to keep some per-project data directly onClusterState, specifically per-project configuration that may be sourced from file-based configuration that we don't want to persist inProjectMetadata. This change includes the following:ReservedClusterStateHandlerhas been reverted to remove the additionalSgeneric type parameter. This type was technically unbounded but in practice could only be one ofClusterStateorProjectMetadata. To simplify things this has been removed and all state handlers (cluster or project level) transform aClusterState.ReservedProjectStateHandlerhas been introduced whosetransform()method accepts aProjectIdin addition to the state object.ReservedClusterStateHandlerimplementations that work at the project level have been converted toReservedProjectStateHandlerthus removing a number of usages of the deprecatedMetadata.getProject()method.