Encapsulate entitlements #128637
Merged
Encapsulate entitlements #128637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an implementation detail that doesn't need to be exposed to the rest of the system.
prdoyle
added
>refactoring
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
May 29, 2025
|
|
||
| requires static org.elasticsearch.entitlement.bridge; // At runtime, this will be in java.base | ||
|
|
||
| exports org.elasticsearch.entitlement.runtime.api; |
There was a problem hiding this comment.
Nit: Should this drop to the lines with the other runtime exports?
There was a problem hiding this comment.
This is the one we proudly export. The others are not supposed to be public, but they currently are of necessity, so I pulled them down into their own section with a TODO.
|
|
||
| private static final Module ENTITLEMENTS_MODULE = PolicyManager.class.getModule(); | ||
|
|
||
| public static InitializeArgs initializeArgs; |
There was a problem hiding this comment.
I figured they are the arguments for the initialize method. Not the best name I ever invented.
| checker = EntitlementInitialization.initChecker(inst, createPolicyManager(initializeArgs.pathLookup())); | ||
| } | ||
|
|
||
| public record InitializeArgs(PathLookup pathLookup) {} |
There was a problem hiding this comment.
Ditto. The problem this solves is that we can't pass arguments directly to the initialize method.
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 30, 2025
* Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented)
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 30, 2025
* Encapsulate entitlements (#128637) * Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented) * Move entitlement checkers to policy package. Maintain parity with main branch to ease backporting.
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented)
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
* Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented)
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
* Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented)
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
* Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few refactorings to hide some more implementation details of entitlements.