Skip to content

[8.19] Fix: Allow non-score sorts in pinned retriever sub-retrievers (#128323) #128654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 8.19
Choose a base branch
from
Open

[8.19] Fix: Allow non-score sorts in pinned retriever sub-retrievers (#128323) #128654

wants to merge 1 commit into from

Conversation

@mridula-s109
Copy link
Contributor

@mridula-s109 mridula-s109 commented May 30, 2025

Backports the following commits to 8.19:

@mridula-s109
Fix: Allow non-score sorts in pinned retriever sub-retrievers (elasti…
540bbce 
…c#128323)

* Fix scoring and sort handling in pinned retriever

* Remove books.es from version control and add to .gitignore

* Remove books.es from version control and add to .gitignore

* Remove books.es entries from .gitignore

* fixed the mess

* Update x-pack/plugin/search-business-rules/src/test/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilderTests.java

Co-authored-by: Copilot <[email protected]>

* Update x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilder.java

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
@mridula-s109 mridula-s109 added :SearchOrg/Relevance Label for the Search (solution/org) Relevance team >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels May 30, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request May 30, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mridula-s109 @elasticsearchmachine