Applying Apache Lucene fix: https://github.com/apache/lucene/pull/14732 #128671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>non-issue
:Search Relevance/Search
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
mayya-sharipova
approved these changes
May 30, 2025
There was a problem hiding this comment.
Thanks for following up on this, @benwtrent.
The change LGTM
|
Converting to draft, we may never need this as we are looking into bug fix apache lucene releases. |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 2, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot (cherry picked from commit 2a44166)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
…8764) * Applying Apache Lucene fix: apache/lucene#14732 (#128671) * Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot (cherry picked from commit 2a44166) * [CI] Auto commit changes from spotless * adding forbidden api check --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 2, 2025
) * Applying Apache Lucene fix: apache/lucene#14732 (#128671) * Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot (cherry picked from commit 2a44166) * adding forbidden APIs check
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
…8671) (elastic#128765) This adds the buggy functions to forbidden API check. Will remove once Lucene is updated. Related elastic#128671
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…8671) (elastic#128765) This adds the buggy functions to forbidden API check. Will remove once Lucene is updated. Related elastic#128671
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Jun 4, 2025
thecoop
added a commit
that referenced
this pull request
Jun 4, 2025
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…8671) (elastic#128765) This adds the buggy functions to forbidden API check. Will remove once Lucene is updated. Related elastic#128671
This was referenced Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mayya-sharipova discovered that applying int sort optimizations unveils a subtle bug with missing values and sorted docvalue queries.
Since this isn't yet a bug that anybody can run into (exposed only when doing int optimized sorting), flagging as a non-issue.
This applies the fix in ES for application in: #127968
The main change here is adjusting all our usages of
IndexSortSortedNumericDocValuesRangeQueryto use the copiedXIndexSortSortedNumericDocValuesRangeQueryAdditionally, in Lucene 10, there are usages in
LongField.newRangeQueryandIntField.newRangeQuery, so, to keep from usingIndexSortSortedNumericDocValuesRangeQueryin those instances, usage of those static methods has been replaced with a new group of static methods.I also added an assert in the
XIndexSortSortedNumericDocValuesRangeQueryto force the removal of this query once we upgrade to a new Lucene minor. We don't want this short cut to rot.NOTE: for the backport, I will have to adjust significantly the
IndexSortSortedNumericDocValuesRangeQuery(copying from Lucene 9) as there are various changes in the 10 branch toIndexSortSortedNumericDocValuesRangeQuerythat we don't want to accidentally apply. I will open a separate PR for review there.