Skip to content

[ES|QL] RERANK command default inferenceId #128685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

[ES|QL] RERANK command default inferenceId #128685

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7005210
[ES|QL] Make inferenceId optional for the `RERANK` command (default t…
afoucret May 30, 2025
ff3ada9
lint
afoucret May 30, 2025
c7fac49
Remove old test.
afoucret May 30, 2025
e24b732
Fix failing test
afoucret May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ rrfCommand
;

rerankCommand
: DEV_RERANK queryText=constant ON rerankFields WITH inferenceId=identifierOrParameter
: DEV_RERANK queryText=constant ON rerankFields (WITH inferenceId=identifierOrParameter)?
;

completionCommand
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.interp
View file
Open in desktop

Large diffs are not rendered by default.

Loading