Skip to content

lucene_snapshot: Only use direct IO when opening with Default IOContext and using the hybrid directory #128697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

lucene_snapshot: Only use direct IO when opening with Default IOContext and using the hybrid directory #128697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions ...n/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.MergeInfo;
import org.elasticsearch.common.util.set.Sets;
import org.elasticsearch.index.store.FsDirectoryFactory;

import java.io.IOException;
import java.util.Set;
Expand Down Expand Up @@ -66,24 +67,30 @@ public FlatVectorsWriter fieldsWriter(SegmentWriteState state) throws IOExceptio
return new Lucene99FlatVectorsWriter(state, vectorsScorer);
}

static boolean shouldUseDirectIO(SegmentReadState state) {
return FsDirectoryFactory.isHybridFs(state.directory);
}

@Override
public FlatVectorsReader fieldsReader(SegmentReadState state) throws IOException {
// only override the context for the random-access use case
SegmentReadState directIOState = state.context.context() == IOContext.Context.DEFAULT
? new SegmentReadState(
if (shouldUseDirectIO(state) && state.context.context() == IOContext.Context.DEFAULT) {
// only override the context for the random-access use case
SegmentReadState directIOState = new SegmentReadState(
state.directory,
state.segmentInfo,
state.fieldInfos,
new DirectIOContext(state.context.hints()),
state.segmentSuffix
)
: state;
// Use mmap for merges and direct I/O for searches.
// TODO: Open the mmap file with sequential access instead of random (current behavior).
return new MergeReaderWrapper(
new Lucene99FlatVectorsReader(directIOState, vectorsScorer),
new Lucene99FlatVectorsReader(state, vectorsScorer)
);
);
// Use mmap for merges and direct I/O for searches.
// TODO: Open the mmap file with sequential access instead of random (current behavior).
return new MergeReaderWrapper(
new Lucene99FlatVectorsReader(directIOState, vectorsScorer),
new Lucene99FlatVectorsReader(state, vectorsScorer)
);
} else {
return new Lucene99FlatVectorsReader(state, vectorsScorer);
}
}

@Override
Expand Down