[CI] Fix testClientsLifeCycleForSingleProject #128718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder. Resolves: elastic#128707
ywangd
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
DaveCTurner
approved these changes
Jun 1, 2025
Comment on lines
209
to
213
| final var e = expectThrows(AlreadyClosedException.class, () -> { | ||
| var client = clientsHolder.client(createRepositoryMetadata(randomFrom(clientName, anotherClientName))); | ||
| client.decRef(); | ||
| }); | ||
| assertThat(e.getMessage(), containsString("Project [" + projectId + "] clients holder is closed")); |
There was a problem hiding this comment.
nit: doing all of this inside the assertBusy() means that we will still pass the test if we temporarily throw a different exception during shutdown. It'd be better if we just looped until we see some exception, and then asserted that the first-thrown exception is an AlreadyClosedException with the right message.
There was a problem hiding this comment.
Makes sense. See b995e28. Thanks!
ywangd
added
the
auto-merge-without-approval
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder. Resolves: #128707
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder. Resolves: elastic#128707
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder. Resolves: elastic#128707
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder. Resolves: elastic#128707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder.
Resolves: #128707