Remove include_default query param from get data stream options.
#128730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
v9.1.0
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
commented
Jun 2, 2025
| public static final TransportVersion ML_INFERENCE_SAGEMAKER_CHAT_COMPLETION_8_19 = def(8_841_0_37); | ||
| public static final TransportVersion ML_INFERENCE_VERTEXAI_CHATCOMPLETION_ADDED_8_19 = def(8_841_0_38); | ||
| public static final TransportVersion INFERENCE_CUSTOM_SERVICE_ADDED_8_19 = def(8_841_0_39); | ||
| public static final TransportVersion DATA_STREAM_OPTIONS_API_REMOVE_INCLUDE_DEFAULTS_8_19 = def(8_841_0_40); |
Contributor
Author
There was a problem hiding this comment.
There is only a backport version because we do not serialise this request anymore in 9.x.
gmarouli
added
the
auto-merge-without-approval
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Jun 3, 2025
…stic#128730) Initially we added to the `include_defaults` to the get data stream options REST API as it was used in the lifecycler API; however, we decided to simplify it and not use it. We remove it now before it gets adopted. (cherry picked from commit 9764730) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 3, 2025
…8730) (#128809) Initially we added to the `include_defaults` to the get data stream options REST API as it was used in the lifecycler API; however, we decided to simplify it and not use it. We remove it now before it gets adopted. (cherry picked from commit 9764730) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…stic#128730) Initially we added to the `include_defaults` to the get data stream options REST API as it was used in the lifecycler API; however, we decided to simplify it and not use it. We remove it now before it gets adopted.
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…stic#128730) Initially we added to the `include_defaults` to the get data stream options REST API as it was used in the lifecycler API; however, we decided to simplify it and not use it. We remove it now before it gets adopted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially we added to the
include_defaultsto the get data stream options REST API as it was used in the lifecycler API; however, we decided to simplify it and not use it. We remove it now before it gets adopted.