Skip to content

Fix computation of last block size in Azure concurrent multipart uploads #128746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Fix computation of last block size in Azure concurrent multipart uploads #128746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d18d7a2
Fix computation of last block size in Azure concurrent multipart uploads
tlrx Jun 2, 2025
9b0f3f2
Update docs/changelog/128746.yaml
tlrx Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/128746.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 128746
summary: Fix computation of last block size in Azure concurrent multipart uploads
area: Snapshot/Restore
type: bug
issues: []
5 changes: 3 additions & 2 deletions ...s/repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureBlobStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,8 +533,9 @@ private static List<MultiPart> computeMultiParts(long totalSize, long partSize)
return List.of(new MultiPart(0, makeMultipartBlockId(), 0L, totalSize, true));
}

long lastPartSize = totalSize % partSize;
int parts = Math.toIntExact(totalSize / partSize) + (0L < lastPartSize ? 1 : 0);
long remaining = totalSize % partSize;
int parts = Math.toIntExact(totalSize / partSize) + (0L < remaining ? 1 : 0);
long lastPartSize = 0L < remaining ? remaining : partSize;

long blockOffset = 0L;
var list = new ArrayList<MultiPart>(parts);
Expand Down
Loading