ESQL: Fix case-insensitive test generation with Unicodes #128753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This excludes from testing the strings containing Unicode chars that change length when changing case.
bpintea
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Jun 2, 2025
| String text = textSupplier.get(); | ||
| return new TextAndPattern(randomCasing(text), escapeString.apply(text)); | ||
| // RegExp doesn't support case-insensitive matching for Unicodes whose length changes when the case changes. | ||
| // Example: a case-insensitive ES regexp query for the pattern `weiß` won't match the value `WEISS` (but will match `WEIß`). |
Contributor
There was a problem hiding this comment.
The example is super useful, thank you!
Contributor
Author
|
Thanks Alex! |
…sitive_with_unicode
bpintea
added
the
auto-merge-without-approval
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Jun 4, 2025
) This excludes from testing the strings containing Unicode chars that change length when changing case. Closes elastic#128705 Closes elastic#128706 Closes elastic#128710 Closes elastic#128711 Closes Closes elastic#128717 Closes elastic#128789 Closes elastic#128790 Closes elastic#128791 Closes (cherry picked from commit 092d4ba)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 5, 2025
) (#128750) (#128753) (#128919) * ESQL: Pushdown constructs doing case-insensitive regexes (#128393) This introduces an optimization to pushdown to Lucense those language constructs that aim at case-insensitive regular expression matching, used with `LIKE` and `RLIKE` operators, such as: * `| WHERE TO_LOWER(field) LIKE "abc*"` * `| WHERE TO_UPPER(field) RLIKE "ABC.*"` These are now pushed as case-insensitive `wildcard` and `regexp` respectively queries down to Lucene. Closes #127479 (cherry picked from commit 0a80916) * ESQL: Fix conversion of a Lucene wildcard pattern to a regexp (#128750) This adds the reserved optional characters to the list that is escaped during conversion. These characters are all enabled by the `RegExp.ALL` flag in our use. Closes #128676, closes #128677. (cherry picked from commit 5eb54bf) * ESQL: Fix case-insensitive test generation with Unicodes (#128753) This excludes from testing the strings containing Unicode chars that change length when changing case. Closes #128705 Closes #128706 Closes #128710 Closes #128711 Closes Closes #128717 Closes #128789 Closes #128790 Closes #128791 Closes (cherry picked from commit 092d4ba) * [CI] Auto commit changes from spotless * Java21 adaptations and automerge fixes * [CI] Auto commit changes from spotless * 8.x's Lucene/RegExp doesn't support case-insensitive matching * [CI] Auto commit changes from spotless * One more Lucene 9 fix --------- Co-authored-by: elasticsearchmachine <[email protected]>
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 5, 2025
…es (elastic#128393) (elastic#128750) (elastic#128753) (elastic#128919)" This reverts commit 34e08fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excludes from testing the strings containing Unicode chars that change length when changing case.
Closes #128705
Closes #128706
Closes #128710
Closes #128711
Closes #128712
Closes #128713
Closes #128714
Closes #128715
Closes #128716
Closes #128717
Closes #128789
Closes #128790
Closes #128791
Closes #128792