Skip to content

Exclude semantic text subfields from field caps POC #128783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Exclude semantic text subfields from field caps POC #128783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions server/src/main/java/org/elasticsearch/action/fieldcaps/FieldCapabilitiesFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

package org.elasticsearch.action.fieldcaps;

import org.elasticsearch.cluster.metadata.InferenceFieldMetadata;
import org.elasticsearch.cluster.metadata.MappingMetadata;
import org.elasticsearch.core.Booleans;
import org.elasticsearch.core.Nullable;
Expand All @@ -30,6 +31,7 @@
import org.elasticsearch.tasks.CancellableTask;

import java.io.IOException;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
Expand Down Expand Up @@ -256,6 +258,13 @@ private static Predicate<MappedFieldType> buildFilter(String[] filters, String[]
Set<String> acceptedTypes = Set.of(fieldTypes);
fcf = ft -> acceptedTypes.contains(ft.familyTypeName());
}

Collection<InferenceFieldMetadata> inferenceFields = context.getMappingLookup().inferenceFields().values();
for (InferenceFieldMetadata inferenceField : inferenceFields) {
Predicate<MappedFieldType> next = ft -> ft.name().startsWith(inferenceField.getName() + ".inference") == false;
Copy link
Contributor Author

@Mikep86 Mikep86 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could use SemanticTextField#getInferenceFieldName here, but I don't think hard-coding .inference here is a big deal overall

fcf = fcf == null ? next : fcf.and(next);
}

for (String filter : filters) {
if ("parent".equals(filter) || "-parent".equals(filter)) {
continue;
Expand All @@ -269,6 +278,7 @@ private static Predicate<MappedFieldType> buildFilter(String[] filters, String[]
};
fcf = fcf == null ? next : fcf.and(next);
}

return fcf;
}

Expand Down