Skip to content

Use a hint to indicate we're reading file footers only #128816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Use a hint to indicate we're reading file footers only #128816

merged 1 commit into from
Jun 3, 2025

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented Jun 3, 2025

Change the instance checks on Store.READONCE_CHECKSUM to a hint

@thecoop thecoop requested a review from ChrisHegarty June 3, 2025 09:45
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jun 3, 2025
ChrisHegarty
ChrisHegarty approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thecoop thecoop added >refactoring :Search Relevance/Search Catch all for Search Relevance and removed needs:triage Requires assignment of a team area label labels Jun 3, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jun 3, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 3, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@thecoop thecoop added v9.1.0 and removed Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Jun 3, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jun 3, 2025
@thecoop
Copy link
Member Author

thecoop commented Jun 3, 2025

BWC failures unrelated

@thecoop thecoop merged commit e99a3a2 into elastic:lucene_snapshot Jun 3, 2025
15 of 19 checks passed
@thecoop thecoop deleted the file-footer-hint branch June 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees

No one assigned

Labels

>refactoring :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thecoop @elasticsearchmachine @ChrisHegarty