ESQL: Add extension point for extra plan checks #128840
Conversation
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
I left some minor comments that I think are just superfluous boilerplate that was likley copy/pasted from some other plugin. This "example" checker plugin will probably eventually get removed anyway when we introduce the "real" things so it's not critical. Otherwise LGTM.
| /** | ||
| * Marker plugin to enable {@link Verifier.ExtraCheckers}. | ||
| */ | ||
| public class ExtraCheckersPlugin extends Plugin {} |
There was a problem hiding this comment.
Is this just because ES requires our plugin to include something that extends Plugin even if we're just providing stuff loaded by SPI?
| @@ -0,0 +1,29 @@ | |||
| apply plugin: 'elasticsearch.internal-es-plugin' | |||
There was a problem hiding this comment.
I think we should actually use elasticsearch.base-internal-es-plugin here, since this is a "test" plugin and not intended to be published or included in Elasticsearch.
| } | ||
|
|
||
| tasks.named('javaRestTest') { | ||
| usesDefaultDistribution("to be triaged") |
There was a problem hiding this comment.
Let's make a best effort to not use the default distribution here. We should avoid adding more tests that use this.
| tasks.named('javaRestTest') { | ||
| usesDefaultDistribution("to be triaged") | ||
| maxParallelForks = 1 | ||
| jvmArgs('--add-opens=java.base/java.nio=ALL-UNNAMED') |
| dependencies { | ||
| compileOnly project(':x-pack:plugin:esql') | ||
| compileOnly project(':x-pack:plugin:esql-core') | ||
| clusterPlugins project(':x-pack:plugin:esql:qa:server:extra-checkers') |
There was a problem hiding this comment.
This should be unnecessary. The internal-es-plugin plugin should automatically add this.
| .distribution(DistributionType.DEFAULT) | ||
| .setting("xpack.security.enabled", "false") | ||
| .setting("xpack.license.self_generated.type", "trial") | ||
| .shared(true) |
There was a problem hiding this comment.
This is unnecessary. There's only one test in this project.
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
3 participants
Adds an extension point so other plugins can add checks that verifier tasks that aren't part of the ESQL plugin.