Generate IndexOrDocValuesQuery for term queries in IpFieldMapper #128846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>enhancement
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Contributor
Author
|
blocked by apache/lucene#14756 |
drempapis
reviewed
Sep 12, 2025
| query = InetAddressPoint.newPrefixQuery("field", InetAddresses.forString(ip), 16); | ||
| assertEquals(new IndexOrDocValuesQuery(query, convertToDocValuesQuery(query)), ft.termQuery(prefix, MOCK_CONTEXT)); | ||
|
|
||
| ft = new IpFieldMapper.IpFieldType("field", true, false); |
Contributor
There was a problem hiding this comment.
For completeness, please consider adding tests that cover the doc values–only case, e.g.
ft = new IpFieldMapper.IpFieldType("field", false, true);
Contributor
Author
|
@drempapis this is block because it changes the way queries behave, e.g some valid queries might hit a |
Member
|
@iverase the idea would be to implement what I suggested in apache/lucene#14756 but I have not had time to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will help if the query is generated in a big conjunction. It should get optimize accordingly.