[9.0] Bugfix: Prevent invalid privileges in manage roles privilege #128847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#128532) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
gmjehovich
added
>bug
:Security/Authorization
|
@jfreden On the original PR, I used another function ( IndexPrivilege.resolveBySelectorAccess() )- but that didn't exist on this branch. I saw this IndexPrivilege.get() function essentially does the same thing, so I wanted to make sure I could use it interchangeably. |
slobodanadamovic
approved these changes
Jun 6, 2025
gmjehovich
added
auto-backport
This was referenced Jun 9, 2025
gmjehovich
added a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Jun 9, 2025
…elastic#128847) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
gmjehovich
added a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Jun 9, 2025
…elastic#128847) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 9, 2025
…) (#129155) This PR addresses the bug reported in [#127496](#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 9, 2025
…) (#129156) This PR addresses the bug reported in [#127496](#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #128532