-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add bucketedSort based on int #128848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bucketedSort based on int #128848
Conversation
Follow up on elastic#127968
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @mayya-sharipova, I've created a changelog YAML for you. |
| } | ||
| } | ||
|
|
||
| public abstract static class ForInts extends BucketedSort { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a BucketedSortForLongsTests should there also be a BucketedSortForIntsTests now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in e3aba40
john-wagster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment; otherwise lgtm
Add bucketedSort on Int
Follow up on #127968