Skip to content

Rename target destination for microbenchmarks #128878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2025
Merged

Rename target destination for microbenchmarks #128878

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
286f857
Rename target destination for microbenchmarks
idegtiarenko Jun 4, 2025
5b6fb9d
Merge branch 'main' into rename_metrics_destination
idegtiarenko Jun 5, 2025
cd4ee51
inline index name
idegtiarenko Jun 5, 2025
7b94802
Merge branch 'main' into rename_metrics_destination
idegtiarenko Jun 6, 2025
9632e31
Merge branch 'main' into rename_metrics_destination
idegtiarenko Jun 10, 2025
b4dcb5d
update credentials path
idegtiarenko Jun 10, 2025
1597efd
fix typo
idegtiarenko Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/hooks/pre-command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fi

if [[ "${USE_PERF_CREDENTIALS:-}" == "true" ]]; then
PERF_METRICS_HOST=$(vault read -field=es_host /secret/ci/elastic-elasticsearch/esbench-metics)
PERF_METRICS_INDEX="dummy-micro-benchmarks"
PERF_METRICS_INDEX="metrics-microbenchmarks-default"
Copy link
Contributor

@breskeby breskeby Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is nothing we read from vault, I wonder if we should just inline that where its used. the precommand hook is usually only used for secure credentials etc.

PERF_METRICS_USERNAME=$(vault read -field=es_username /secret/ci/elastic-elasticsearch/esbench-metics)
PERF_METRICS_PASSWORD=$(vault read -field=es_password /secret/ci/elastic-elasticsearch/esbench-metics)

Expand Down