Skip to content

ES|QL: Split JOIN yaml tests so that non-alias queries run also on bwc #128884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

ES|QL: Split JOIN yaml tests so that non-alias queries run also on bwc #128884

merged 4 commits into from
Jun 4, 2025

Conversation

@luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Jun 4, 2025 •
edited
Loading

Making JOIN yaml tests more granular (lookup on aliases in its own yml file), so that they keep running on bwc.
Also fixing an error message.

Fixes: #128850
Fixes: #128849
Fixes: #128856
Fixes: #128855

@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.19.0 labels Jun 4, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0 labels Jun 4, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 4, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila luigidellaquila merged commit 8db3ee4 into elastic:main Jun 4, 2025
18 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 4, 2025

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128884

luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Jun 4, 2025
@luigidellaquila
ES|QL: Split JOIN yaml tests so that non-alias queries run also on bwc (
a251954 
elastic#128884)
@luigidellaquila luigidellaquila mentioned this pull request Jun 4, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jun 4, 2025
@luigidellaquila
ES|QL: Split JOIN yaml tests so that non-alias queries run also on bwc (
f00d907 
#128902)

* ES|QL: Split JOIN yaml tests so that non-alias queries run also on bwc (#128884)

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

3 participants

@luigidellaquila @elasticsearchmachine @idegtiarenko