Skip to content

Re-enable vector.rescoring.directio #128898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2025
Merged

Re-enable vector.rescoring.directio #128898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dfe9bc9
re-enable direct io
ChrisHegarty Jun 4, 2025
4dbd081
Merge branch 'main' into reenable_dio
ChrisHegarty Jun 11, 2025
9b52ba1
unmute
ChrisHegarty Jun 11, 2025
50d552b
Merge branch 'main' into reenable_dio
ChrisHegarty Jun 16, 2025
46219cd
Merge branch 'main' into reenable_dio
ChrisHegarty Jun 16, 2025
f7eabf0
Merge branch 'main' into reenable_dio
ChrisHegarty Jun 16, 2025
13ef78c
Merge branch 'main' into reenable_dio
ChrisHegarty Jun 16, 2025
7451b56
Merge branch 'main' into reenable_dio
ChrisHegarty Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,9 +478,6 @@ tests:
- class: org.elasticsearch.index.codec.vectors.es818.ES818BinaryQuantizedVectorsFormatTests
method: testSimpleOffHeapSizeFSDir
issue: https://github.com/elastic/elasticsearch/issues/128800
- class: org.elasticsearch.index.store.DirectIOIT
method: testDirectIOUsed
issue: https://github.com/elastic/elasticsearch/issues/128829
- class: org.elasticsearch.packaging.test.DockerTests
method: test150MachineDependentHeap
issue: https://github.com/elastic/elasticsearch/issues/128120
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
@SuppressForbidden(reason = "Copied from lucene")
public class DirectIOLucene99FlatVectorsReader extends FlatVectorsReader implements OffHeapStats {

private static final boolean USE_DIRECT_IO = Boolean.parseBoolean(System.getProperty("vector.rescoring.directio", "false"));
private static final boolean USE_DIRECT_IO = Boolean.parseBoolean(System.getProperty("vector.rescoring.directio", "true"));

private static final long SHALLOW_SIZE = RamUsageEstimator.shallowSizeOfInstance(DirectIOLucene99FlatVectorsReader.class);

Expand Down