Use binarySearch over terms instead of automaton in termsQueries on Wildcard fields #128920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
mayya-sharipova
approved these changes
Jun 5, 2025
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@iverase Very Nice optimization! it makes sense to use bytes comparison instead of Automaton for this case.
I was trying to think of case where Automaton will allow to capture us something more than a simple byte comparison, but could not find any.
iverase
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need of using automatons to match terms on wildcard fields. This PR addresses this issue by adding a BinaryDvConfirmedTermsQuery to execute terms queries which uses binary search over terms instead of an automaton.
We are currently only using it to match one term at a time but the plan is to use it for terms queries too.