Skip to content

[8.19] Add clarification to semantic_text documentation on default quantization and lexical search support #128990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

[8.19] Add clarification to semantic_text documentation on default quantization and lexical search support #128990

merged 2 commits into from
Jun 5, 2025

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Jun 5, 2025

Applies the clarifications in #128927 to our 8.19 docs.

@kderusso kderusso added >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.0 labels Jun 5, 2025
@kderusso kderusso requested review from leemthompo and a team June 5, 2025 13:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Relevance The Search organization Search Relevance team labels Jun 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

afoucret
afoucret approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@afoucret afoucret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall OK but I wonder if we should indicate that some options does not have any effect with a semantic text field (fuzziness and related options like prefix_length, minimum_should_match, ...)

@kderusso
Copy link
Member Author

kderusso commented Jun 5, 2025

@afoucret I think it's OK because we link to the match docs and it's explicit there, I'll keep this for now as it's consistent with the changes to 9.1. If it's unclear we can always followup in the future. Thanks!

@kderusso kderusso merged commit c833893 into elastic:8.19 Jun 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afoucret afoucret afoucret approved these changes

@leemthompo leemthompo Awaiting requested review from leemthompo

Assignees
No one assigned
Labels
>docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Docs Meta label for docs team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kderusso @elasticsearchmachine @afoucret