Relax snapshot repo backup docs #129040
Merged
Relax snapshot repo backup docs #129040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now ok to mark a repository as `readonly: true` while taking a backup, so this commit reinstates the docs that say this. Relates elastic#93575 Reverts elastic#115062 Reverts elastic#115071 Relates elastic#128296
DaveCTurner
added
>docs
|
Documentation preview: |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
added a commit
to DaveCTurner/elastic-docs-content
that referenced
this pull request
Jun 6, 2025
It's now ok to mark a repository as `readonly: true` while taking a backup, so this commit reinstates the docs that say this. Relates elastic/elasticsearch#93575 Reverts elastic/elasticsearch#115062 Reverts elastic/elasticsearch#115071 Relates elastic/elasticsearch#128296 Relates elastic/elasticsearch#129040
DaveCTurner
added a commit
to elastic/docs-content
that referenced
this pull request
Jun 6, 2025
It's now ok to mark a repository as `readonly: true` while taking a backup, so this commit reinstates the docs that say this. Relates elastic/elasticsearch#93575 Reverts elastic/elasticsearch#115062 Reverts elastic/elasticsearch#115071 Relates elastic/elasticsearch#128296 Relates elastic/elasticsearch#129040
yetanothertw
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Looks good!
A minor nitpick is that the change in PR#1625 in the docs-content repo reads a bit clearer (even if it's more verbose):
Prevent writes to the repository by unregistering the repository from the cluster which has write access to it, or by registering it with readonly: true.
I'll leave it up to you if you want to update it for consistency.
Many thanks.
DaveCTurner
added
the
auto-merge-without-approval
|
👍 done |
DaveCTurner
deleted the
2025/06/06/revert-115062-readonly-repo-during-backup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now ok to mark a repository as
readonly: truewhile taking abackup, so this commit reinstates the docs that say this.
Relates #93575
Reverts #115062
Reverts #115071
Relates #128296