Skip to content

Fix vault field name #129184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged

Fix vault field name #129184

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
472588c
Fix vault field name
idegtiarenko Jun 10, 2025
97f22b5
Merge branch 'main' into fix_vault_field_name
idegtiarenko Jun 10, 2025
11a6464
Merge branch 'main' into fix_vault_field_name
idegtiarenko Jun 10, 2025
5b7c642
Merge branch 'main' into fix_vault_field_name
idegtiarenko Jun 10, 2025
3ec315a
Merge branch 'main' into fix_vault_field_name
idegtiarenko Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/hooks/pre-command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fi

if [[ "${USE_PERF_CREDENTIALS:-}" == "true" ]]; then
PERF_METRICS_HOST=$(vault read -field=es_host /secret/ci/elastic-elasticsearch/microbenchmarks-metrics)
PERF_METRICS_USERNAME=$(vault read -field=es_username /secret/ci/elastic-elasticsearch/microbenchmarks-metrics)
PERF_METRICS_USERNAME=$(vault read -field=es_user /secret/ci/elastic-elasticsearch/microbenchmarks-metrics)
Copy link
Contributor

@gbanasiak gbanasiak Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually my mistake, as we're using es_username elsewhere. I can change the original Infra Vault secret instead?

Copy link
Contributor Author

@idegtiarenko idegtiarenko Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, this is a copy in /ci/ and may use a different convention

PERF_METRICS_PASSWORD=$(vault read -field=es_password /secret/ci/elastic-elasticsearch/microbenchmarks-metrics)

export PERF_METRICS_HOST
Expand Down